[BUGFIX] Fix Web Loading Bar (Again) #2553
Merged
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesisfeline
approved these changes
May 19, 2024
|
for the hardcoded value, i just eyeballed what I personally think looked nice! I will put this PR into da queue for review! |
lemz1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi,
sorry for making another fix for the loading bar. I messed some stuff up.
setGraphicSize, which lead the loading bar to go back and forth when no callbacks have been finished. The comment in the code explains that part.I do have a question about the lerp though. Is there a particular reason why we are using
FlxMath.lerpand using a hardcoded ratio instead ofelapsed. Another thing i'd like to mention is that the loading bar doesn't reach the end when finishing all callbacks before switching to the next state because the lerp needs to take some time.